Jpos hangs on response 204

[mpp-jamesl]

Jpos server hangs on HttpResponse 204

When sending a request to an API which returns a 204 on success.

If you need to have the responseBodyOnError = true
and the API sends back a 204 on success the Jpos server just hangs. The issue is around the following code within the HttpQuery class

boolean includeResponse= (sc == HttpStatus.SC_CREATED) || (sc == HttpStatus.SC_OK) || responseOnError; if (includeResponse) { try { ctx.put (responseName, EntityUtils.toString(result.getEntity())); } catch (IOException e) { ctx.log (e); } }

The actual problem is in this line
ctx.put (responseName, EntityUtils.toString(result.getEntity()));

It is because the EntityUtils is attempting to convert the result.getEntity into an entity to assign as the value for the response name in the context map, in this case the result is actually null so instead of the EntityUtils throwing an exception, it just causes the server to hang.

This causes a hang because the response does not have a body given the 204.

There should be null safety checks here and if the result.getEntity is null then assign the status value (sc) to the context instead.