Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DTD used from the SourceForge one to the hibernate one #251

Closed
chhil opened this issue Jul 4, 2022 · 4 comments · Fixed by #273
Closed

Change DTD used from the SourceForge one to the hibernate one #251

chhil opened this issue Jul 4, 2022 · 4 comments · Fixed by #273

Comments

@chhil
Copy link
Contributor

chhil commented Jul 4, 2022

Change

SYSTEM "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">

and

SYSTEM "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">

from

<!DOCTYPE hibernate-mapping
  SYSTEM "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">

to

<!DOCTYPE hibernate-mapping 
  SYSTEM "http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd">
@ar ar closed this as completed in 06859fa Jul 4, 2022
@ar ar reopened this Jul 4, 2022
@ar
Copy link
Member

ar commented Jul 4, 2022

Not that easy - see https://github.com/jpos/jPOS-EE/runs/7183459332?check_suite_focus=true#step:7:3843

[org.xml.sax.SAXParseException; cvc-complex-type.3.2.2: Attribute 'generated' is not allowed to appear in element 'property'.]
            at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.handleStreamException(UnmarshallerImpl.java:396)
            at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0(UnmarshallerImpl.java:377)
            at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java:350)
            at org.hibernate.boot.cfgxml.internal.JaxbCfgProcessor.unmarshal(JaxbCfgProcessor.java:127)

@ar ar closed this as completed Jul 4, 2022
@ar ar reopened this Jul 4, 2022
@barspi
Copy link
Contributor

barspi commented Dec 14, 2022

Only Status.hbm.xml and StatusTag.hbm.xml are using the sourceforge DTD
All other entities in all other jPOS-EE modules are using http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd and it seems to work, or at least they don't give that error.

@ar
Copy link
Member

ar commented Dec 16, 2022

Can you send a PR @barspi ?

@barspi
Copy link
Contributor

barspi commented Dec 17, 2022

Sent #273

@ar ar closed this as completed in #273 Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants