-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Debug participant extend the doPrepare(...) method to get profile dump the debug participant's timing info #256
Comments
This may not be an issue. I had the debug flag set to true and the debug participant added, this ended up creating 2 context loggings for one transaction. I kept the flag and removed the participant and one entry got logged and the profiler entry for debug got logged too. However I did notice that the commit entry in the log did not have a commit id.
Is this expected? |
The Debug participant functionality have been incorporated into the TransactionManager itself. The main reason for doing that was to emit in the same LogEvent profiling information. We don't have Debug and Trace events separated anymore, they get automatically emitted by the TM at the end of every transaction (provided the debug is on, which is usually the case). Regarding the commit ID, it's right there: |
Maybe we can document the following. If you use the debug flag don't use the debug participant, otherwise you end up with 2 context log entries in the log. |
Done in jPOS-EE (bc9ceff). jPOS-EE.pdf has been updated, the new notice looks like this: |
jPOS-EE/modules/txn/src/main/java/org/jpos/transaction/Debug.java
Lines 26 to 29 in 6fbb795
Since Debug.java extends the TxnSupport's prepare(...) method instead of doPrepare(...) the profiler does not create the checkpoint and no timing info is available for the debug participant.
Similarly abort can be changed to doPrepareForAbort(...)
The text was updated successfully, but these errors were encountered: