Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q2 log shows deploy file renamed to bad but its not actually renamed. #289

Closed
chhil opened this issue Mar 23, 2020 · 1 comment
Closed

Q2 log shows deploy file renamed to bad but its not actually renamed. #289

chhil opened this issue Mar 23, 2020 · 1 comment

Comments

@chhil
Copy link
Contributor

chhil commented Mar 23, 2020 •
edited
Loading

https://github.com/jpos/jPOS/blob/master/jpos/src/main/java/org/jpos/q2/Q2.java#L932-L939

The java File.renameTo returns a boolean, and we should use that flag and log the appropriate error if it was renamed or an attempt to rename failed.
@chhil chhil changed the title Q2 log shows deply file renamed to bad but its not actually renamed. Q2 log shows deploy file renamed to bad but its not actually renamed. Mar 23, 2020
chhil added a commit to chhil/jPOS that referenced this issue Mar 23, 2020
@chhil
Update Q2.java
85dd6fb 
jpos#289
Check if rename succeeded and log appropriate message to Q2 log.
@chhil chhil mentioned this issue Mar 23, 2020
Merged
@ar
Copy link
Member

ar commented Mar 23, 2020

Fixed in #290

@ar ar closed this as completed Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ar @chhil