Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override move test timeout #398

Merged
merged 1 commit into from Mar 27, 2017
Merged

Don't override move test timeout #398

merged 1 commit into from Mar 27, 2017

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Mar 22, 2017

This issue with graceful-fs has been fixed, so no need for this.

@manidlou
Copy link
Collaborator

@RyanZim moveSync() has that timeout too: https://github.com/jprichardson/node-fs-extra/blob/master/lib/move-sync/__tests__/move-sync.test.js#L117. Would you please take care of that too? or let me know if you want me to do it 😄

@RyanZim
Copy link
Collaborator Author

RyanZim commented Mar 23, 2017

Oops, yes, I'll fix that.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.277% when pulling afab94b on windows-timeout into ed5dc63 on master.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Mar 27, 2017

Merging this since JP is extra busy and this change only affects tests.

@RyanZim RyanZim merged commit b549b04 into master Mar 27, 2017
@RyanZim RyanZim deleted the windows-timeout branch March 27, 2017 19:53
@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manidlou manidlou manidlou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RyanZim @manidlou @coveralls