Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version #92

Closed
kellyselden opened this issue Sep 12, 2017 · 9 comments
Closed

Release new version #92

kellyselden opened this issue Sep 12, 2017 · 9 comments
Assignees

Comments

@kellyselden
Copy link
Contributor

Would you mind releasing #89?

@jprichardson
Copy link
Owner

@RyanZim please release this - should do major.

@RyanZim
Copy link
Collaborator

RyanZim commented Sep 12, 2017

@jprichardson I assume kill 0.10, 0.12, & io.js support while we're at it?

@RyanZim RyanZim self-assigned this Sep 12, 2017
@kellyselden
Copy link
Contributor Author

It seems to me this is only additive, not breaking, so it could be a minor release. That way I can use it sooner in fs-extra without a major bump there.

@jprichardson
Copy link
Owner

I assume kill 0.10, 0.12, & io.js support while we're at it?

Yes.

@RyanZim
Copy link
Collaborator

RyanZim commented Sep 12, 2017

jsonfile 4.0.0 released 🎉 Will release in fs-extra as a patch release soon, hopefully tonight. Refs jprichardson/node-fs-extra#491

@RyanZim RyanZim closed this as completed Sep 12, 2017
@kellyselden
Copy link
Contributor Author

Thanks @RyanZim

@RyanZim
Copy link
Collaborator

RyanZim commented Sep 12, 2017

@kellyselden Released in fs-extra 4.0.2 🎉

@estaub
Copy link

estaub commented Sep 28, 2017

@RyanZim you might want to put a note in the readme about what's considered a breaking change; folks like me try to understand before updating, it took a while to get here to this issue.

@RyanZim
Copy link
Collaborator

RyanZim commented Sep 28, 2017

@estaub The info is in the CHANGELOG file: https://github.com/jprichardson/node-jsonfile/blob/master/CHANGELOG.md#400--2017-07-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants