New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain specific / break up into smaller modules #10

Open
tj opened this Issue Sep 27, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@tj

tj commented Sep 27, 2012

might be worth breaking this into a few smaller ones and adding them as deps for string.js.

for example https://github.com/component/trim is domain-specific, vs a mixed bag of utils. mixed bags are fine if you plan on using them all etc, but there's no reason we can't split these up so it's more useful as deps to other components

few good candidates:

@jprichardson

This comment has been minimized.

Show comment
Hide comment
@jprichardson

jprichardson Oct 3, 2012

Owner

Hmm, maybe you have a point. I'm trying to think of the best way to manage all of the individual subcomponents, I suppose I could just use Git submodules and have a Makescript pull the latest from each one to build string.min.js. Any thoughts on this?

Owner

jprichardson commented Oct 3, 2012

Hmm, maybe you have a point. I'm trying to think of the best way to manage all of the individual subcomponents, I suppose I could just use Git submodules and have a Makescript pull the latest from each one to build string.min.js. Any thoughts on this?

@tj

This comment has been minimized.

Show comment
Hide comment
@tj

tj Oct 3, 2012

i'd just make them regular component deps and re-export their methods

tj commented Oct 3, 2012

i'd just make them regular component deps and re-export their methods

@tj

This comment has been minimized.

Show comment
Hide comment
@tj

tj Oct 3, 2012

then --standalone build if people want to use it without component

tj commented Oct 3, 2012

then --standalone build if people want to use it without component

@jprichardson

This comment has been minimized.

Show comment
Hide comment
@jprichardson

jprichardson Sep 2, 2014

Owner

I'm still a huge fan of doing this. Just not willing to make the time because of other priorities ATM. Will address in the future.

Owner

jprichardson commented Sep 2, 2014

I'm still a huge fan of doing this. Just not willing to make the time because of other priorities ATM. Will address in the future.

@az7arul az7arul reopened this Jun 1, 2015

@az7arul az7arul added the 4 label Jun 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment