Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiddler Extension States it is the latest version, however it is not. #23

Closed
Mike-Crowley opened this issue Jan 3, 2019 · 5 comments
Closed
Assignees
Labels
Fix Known Fix coming in next release

Comments

@Mike-Crowley
Copy link

Mike-Crowley commented Jan 3, 2019

V 1.0.60 reports its the latest version, despite the availability of later versions. (when using the check for updates button)

@jprknight
Copy link
Owner

Thanks for the report Mike. Looking into this.

@jprknight
Copy link
Owner

Completed some testing in this area. What ever is going on here is being carried forward in code.

@jprknight
Copy link
Owner

CheckForUpdate() call not called in new alpha build.

public void OnLoad()

        // Check for update. Do this first as we alter the Exchange Online menu title according to
        // whether an update is available.
        //CheckForAppUpdate calledCheckForAppUpdate = new CheckForAppUpdate();
        //calledCheckForAppUpdate.CheckForUpdate();

@jprknight
Copy link
Owner

jprknight commented Mar 8, 2019

New updates for this.

CheckForAppUpdate.cs:

    private static CheckForAppUpdate _instance;

    public static CheckForAppUpdate Instance => _instance ?? (_instance = new CheckForAppUpdate());

    public void Initialize()
    {
        this.CheckForUpdate();
    }

ActivationService.cs:

public async void OnLoad()
{
MenuUI.Instance.Initialize();
ColumnsUI.Instance.Initialize();
SessionProcessor.Instance.Initialize();
CheckForAppUpdate.Instance.Initialize();
}

SessionProcessor.cs:

CheckForAppUpdate.Instance.CheckForUpdate();

@jprknight jprknight self-assigned this Mar 8, 2019
@jprknight jprknight added the Fix Known Fix coming in next release label Mar 8, 2019
@jprknight
Copy link
Owner

Check for update mechanism changed entirely. Fixed in new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Known Fix coming in next release
Projects
None yet
Development

No branches or pull requests

2 participants