Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White card text not visible when dark mode is enabled #16

Closed
jayson528 opened this issue Oct 24, 2019 · 4 comments
Closed

White card text not visible when dark mode is enabled #16

jayson528 opened this issue Oct 24, 2019 · 4 comments

Comments

@jayson528
Copy link
Contributor

@jayson528 jayson528 commented Oct 24, 2019

Hey, i noticed that the WhiteCard text is not visible when dark mode is enabled in iOS 13. The label textColor for the WhiteCards was never set, so by default it will turn white with dark mode enabled.

Im going to submit a PR for the fix in about 5 minutes.

Dark mode disabled:
image

Dark mode enabled:
image

@jpsim

This comment has been minimized.

Copy link
Owner

@jpsim jpsim commented Oct 24, 2019

I'm amazed someone out there is still running this 😆

@jayson528

This comment has been minimized.

Copy link
Contributor Author

@jayson528 jayson528 commented Oct 24, 2019

To be completely honest with you i'm doing these for school and i was trying to replicate the other bugs and by complete accident stumbled upon it. Do you mind if i make a separate PR to fix the constraints to fit the iPhone 10 display? @jpsim

@jpsim

This comment has been minimized.

Copy link
Owner

@jpsim jpsim commented Oct 24, 2019

That'd be great, thanks for your help.

@jpsim

This comment has been minimized.

Copy link
Owner

@jpsim jpsim commented Oct 24, 2019

Fixed in #17.

@jpsim jpsim closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.