PeerKit Additions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 28, 2014 12:45
This reverts commit 875a9b8.
| @@ -11,41 +11,52 @@ import MultipeerConnectivity | |||
|
|
|||
| // MARK: Type Aliases | |||
|
|
|||
| public typealias PeerBlock = ((peerID: MCPeerID) -> Void) | |||
| public typealias PeerBlock = ((myPeerID:MCPeerID, peerID: MCPeerID) -> Void) | |||
There was a problem hiding this comment.
Could you add a space here to match the rest of the code? myPeerID: MCPeerID
|
This is fantastic, @alexanderjarvis! Thanks for the PR. I'll merge it once you address my two very minor comments. |
added 2 commits
January 22, 2015 11:57
|
@jpsim done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for writing PeerKit. I made some local additions, mostly delegate methods that weren't implemented, including sending and receiving resources.
I also added a way to customise the display name as it was just the device UUID by default with no way of changing it.
Also, a way to stop transceiving that disconnects the sessions and the ability to set a new Transceiver e.g. when the display name is changed by a user.
Thanks