Add setting to hide concert pitch menu #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very Zen! I like this change but would suggest renaming "Hide Concert Pitch" to "Hide Transposition Menu" since that's indeed what it does. Like if the only instrument I play is in Bb, then I can set the transposition to Bb, hide the transposition menu and I'm all in on the zen lifestyle. I'm not hiding the concert pitch at this point, I'm hiding the menu. |
|
@jpsim updated! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting in Settings.app to hide the concert pitch menu. For extra zen.
The setting defaults to off. Unless you change it, the experience will be exactly the same as before this PR.