Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daylight saving time #2

Closed
jpulakka opened this issue Nov 15, 2021 · 2 comments
Closed

Daylight saving time #2

jpulakka opened this issue Nov 15, 2021 · 2 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@jpulakka
Copy link
Owner

DST is probably not handled correctly right now. We just read "today" and "tomorrow" attributes (which are typically 24-element lists) from nordpool, and assume that there are 24 hours in day and thus dt.now().hour gives index to current hour in "today" list. Too many assumptions there. Possibly there will be 25 elements in the list when moving from summer to winter, and 23 elements in the opposite case.

If EU gets rid of DST then this issue goes away without changing anything. Need to see to prioritize.

@jpulakka jpulakka added the bug Something isn't working label Nov 15, 2021
@jpulakka jpulakka self-assigned this Nov 15, 2021
@jpulakka
Copy link
Owner Author

jpulakka commented Apr 4, 2022

Both winter and summer times work correctly, but the transition does not. Minor bug.

@jpulakka
Copy link
Owner Author

This works correctly with entso-e / v0.2.0. Won't fix nordpool (which is off by 1 hour two days in year, that's all).

@jpulakka jpulakka closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2022
@jpulakka jpulakka added the wontfix This will not be worked on label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant