Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countries with ISO codes #11

Open
JoshuaBehrens opened this issue Sep 5, 2022 · 1 comment
Open

Countries with ISO codes #11

JoshuaBehrens opened this issue Sep 5, 2022 · 1 comment

Comments

@JoshuaBehrens
Copy link

Is it beneficial and match this project's goals to add more quality to the data? Looking up countries by their name is hasslesome. For better working with the data I'd like to see some alpha3 codes based on ISO 3166-1.

@jpwhite3
Copy link
Owner

In general I'm a big fan of improving data quality, structure, and testability. That said, I started the codebase to use as a teaching tool in a classroom environment and I'm sensitive that other may be using it for the same purposes. So I want to be careful not to introduce breaking changes without conversation.

Adding a column for ISO codes sounds like a reasonable new feature that shouldn't break existing functionality, so I'm open to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants