-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-f filename crashes jq on windows #1072
Comments
I'm not sure what is happening here:
|
This again lets it crash:
[Using The problem is that this is the way which would be used by a git diff driver ala
This would result in the following two calls to jq:
|
Was one of the crashes a result of using long paths? The maximum path length on Windows is 260 bytes. I've tried using Windows-style paths and those work for me, so that's not it. Non-existent paths also don't cause jq to crash on Windows. As for program file contents as UTF-8 with a BOM... Hmmm, perhaps we should support that, yes. This does crash jq for me: |
re long path: that's the exact command:
Re renamed ipynb: same here: renaming it to json works. But the above does not, it still crashes if I use the above I try to implement this: https://gist.github.com/takluyver/bc8f3275c7d34abb68bf by using this file: https://gist.github.com/jfeist/cd00aa3b681092e1d5dc I no got it to work by using this batch file as a git diff textconv, but this is a kind of hack :-( :
|
@JanSchulz There are things I can do to crash jq, but the command you give (with slightly different directory names) works for me. Oddly, I get it to crash when the data file path is absolute and that long. The failure happens when I use |
Oh, I think I know what it is. The result of |
Yes, that fixes it. @dtolnay Should we now make a 1.6 or a 1.5.1 release? What think ye? |
I wish I could attach executables here... |
Getting the jq.exe from here: https://ci.appveyor.com/project/JanSchulz/jq/build/1.0.27/artifacts (#1074) I can comfim, that this works now:
Will test the rest later... |
@nicowilliams @dtolnay any news on a new release? |
The only way I'd do a release is if we just release master in its current state as either 1.5.1 or 1.6 (I prefer 1.6). I'm not up for backporting bug fixes to the 1.5 branch (which is gone but can get recreated from the |
I want to use jq as a git smudge filter for ipython notebooks, but when I tried to run jq with
jq -f c:\path\to\ipynb_filter.jq
, it crashes: "jq does not work anymore" popup and the question if I want to debug (which I have no idea how to do: I only see some "exception at "...).The text was updated successfully, but these errors were encountered: