Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed flex-direction for rbc-toolbar mobile #2497

Merged
merged 1 commit into from Feb 9, 2024

Conversation

hunter-madsen
Copy link
Contributor

@hunter-madsen hunter-madsen commented Feb 8, 2024

This request is to add in a css change that helps fix toolbar wrapping when the display is too small. This issue was brought up here - #1699. This should help cleanup some undesirable toolbar displays for mobile users.

Bellow are some screenshots that show the issue I was describing. On mobile devices, if the selected date is too long then it will get wrapped beneath the "Today, Back, Next" buttons. This change will stack these three elements in a column for smaller display widths which helps it to look cleaner and prevents the button positions from shifting while scrolling through dates using the "next" button. Essentially, it will make all cases look like the second picture regardless of date length.

image

image

@cutterbl cutterbl merged commit 8d7b20d into jquense:master Feb 9, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
## [1.9.2](v1.9.1...v1.9.2) (2024-02-09)

### Bug Fixes

* changed flex-direction for rbc-toolbar mobile ([#2497](#2497)) ([8d7b20d](8d7b20d)), closes [#1699](#1699)
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to additio/react-big-calendar that referenced this pull request Mar 12, 2024
# [1.1.0](v1.0.0...v1.1.0) (2024-03-12)

### Bug Fixes

* add isBackgroundEvent to onSelectEvent event obj ([jquense#2491](https://github.com/additio/react-big-calendar/issues/2491)) ([fdbb496](fdbb496))
* **ARIA:** remove tabindex ([jquense#2508](https://github.com/additio/react-big-calendar/issues/2508)) ([7e01c3d](7e01c3d)), closes [jquense#2498](https://github.com/additio/react-big-calendar/issues/2498)
* changed flex-direction for rbc-toolbar mobile ([jquense#2497](https://github.com/additio/react-big-calendar/issues/2497)) ([8d7b20d](8d7b20d)), closes [jquense#1699](https://github.com/additio/react-big-calendar/issues/1699)
* day events sort fixed ([jquense#2512](https://github.com/additio/react-big-calendar/issues/2512)) ([ac1ff00](ac1ff00))
* **DnD:** dragAndDrop EventWrapper.js error: cannot add property 'X', object is not extensible ([0c4826a](0c4826a))
* **dnd:** move merge components ([fd02261](fd02261)), closes [jquense#2359](https://github.com/additio/react-big-calendar/issues/2359)
* fixing invalid ref with invalid scrollHeight ([jquense#2459](https://github.com/additio/react-big-calendar/issues/2459)) ([a4bc8f3](a4bc8f3))
* Modify events.js ([jquense#2444](https://github.com/additio/react-big-calendar/issues/2444)) ([2a838d9](2a838d9))
* replace deprecated onKeyPress by onKeyDown ([21f51f2](21f51f2))
* **rtl DnD:** Dragging an event in the RTL month view calendar gets confused to the wrong side ([jquense#2426](https://github.com/additio/react-big-calendar/issues/2426)) ([ebe8c2c](ebe8c2c)), closes [jquense#2310](https://github.com/additio/react-big-calendar/issues/2310) [jquense#1801](https://github.com/additio/react-big-calendar/issues/1801)
* scrollToTime does not work properly, when min specified ([jquense#2051](https://github.com/additio/react-big-calendar/issues/2051)) ([04c1888](04c1888))
* to build ([jquense#2517](https://github.com/additio/react-big-calendar/issues/2517)) ([621fc7e](621fc7e))
* typo ([jquense#2443](https://github.com/additio/react-big-calendar/issues/2443)) ([407e168](407e168))

### Features

* add citation file ([jquense#2523](https://github.com/additio/react-big-calendar/issues/2523)) ([3de0059](3de0059))
* **allDayMaxRows:** Allow for more granular control ([36871bf](36871bf)), closes [jquense#2386](https://github.com/additio/react-big-calendar/issues/2386)
* **event sort:** update event sort for multi day ([jquense#2502](https://github.com/additio/react-big-calendar/issues/2502)) ([ff209d0](ff209d0))
* showMore message add event info ([jquense#2496](https://github.com/additio/react-big-calendar/issues/2496)) ([18012b7](18012b7))
* Support multiple resources on an event ([91155c5](91155c5)), closes [jquense#2405](https://github.com/additio/react-big-calendar/issues/2405) [jquense#1649](https://github.com/additio/react-big-calendar/issues/1649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants