fix(ARIA): remove tabindex #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tabindex, applied to the event div, creates invalid ARIA component nesting #2498
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to additio/react-big-calendar
that referenced
this pull request
Mar 12, 2024
# [1.1.0](v1.0.0...v1.1.0) (2024-03-12) ### Bug Fixes * add isBackgroundEvent to onSelectEvent event obj ([jquense#2491](https://github.com/additio/react-big-calendar/issues/2491)) ([fdbb496](fdbb496)) * **ARIA:** remove tabindex ([jquense#2508](https://github.com/additio/react-big-calendar/issues/2508)) ([7e01c3d](7e01c3d)), closes [jquense#2498](https://github.com/additio/react-big-calendar/issues/2498) * changed flex-direction for rbc-toolbar mobile ([jquense#2497](https://github.com/additio/react-big-calendar/issues/2497)) ([8d7b20d](8d7b20d)), closes [jquense#1699](https://github.com/additio/react-big-calendar/issues/1699) * day events sort fixed ([jquense#2512](https://github.com/additio/react-big-calendar/issues/2512)) ([ac1ff00](ac1ff00)) * **DnD:** dragAndDrop EventWrapper.js error: cannot add property 'X', object is not extensible ([0c4826a](0c4826a)) * **dnd:** move merge components ([fd02261](fd02261)), closes [jquense#2359](https://github.com/additio/react-big-calendar/issues/2359) * fixing invalid ref with invalid scrollHeight ([jquense#2459](https://github.com/additio/react-big-calendar/issues/2459)) ([a4bc8f3](a4bc8f3)) * Modify events.js ([jquense#2444](https://github.com/additio/react-big-calendar/issues/2444)) ([2a838d9](2a838d9)) * replace deprecated onKeyPress by onKeyDown ([21f51f2](21f51f2)) * **rtl DnD:** Dragging an event in the RTL month view calendar gets confused to the wrong side ([jquense#2426](https://github.com/additio/react-big-calendar/issues/2426)) ([ebe8c2c](ebe8c2c)), closes [jquense#2310](https://github.com/additio/react-big-calendar/issues/2310) [jquense#1801](https://github.com/additio/react-big-calendar/issues/1801) * scrollToTime does not work properly, when min specified ([jquense#2051](https://github.com/additio/react-big-calendar/issues/2051)) ([04c1888](04c1888)) * to build ([jquense#2517](https://github.com/additio/react-big-calendar/issues/2517)) ([621fc7e](621fc7e)) * typo ([jquense#2443](https://github.com/additio/react-big-calendar/issues/2443)) ([407e168](407e168)) ### Features * add citation file ([jquense#2523](https://github.com/additio/react-big-calendar/issues/2523)) ([3de0059](3de0059)) * **allDayMaxRows:** Allow for more granular control ([36871bf](36871bf)), closes [jquense#2386](https://github.com/additio/react-big-calendar/issues/2386) * **event sort:** update event sort for multi day ([jquense#2502](https://github.com/additio/react-big-calendar/issues/2502)) ([ff209d0](ff209d0)) * showMore message add event info ([jquense#2496](https://github.com/additio/react-big-calendar/issues/2496)) ([18012b7](18012b7)) * Support multiple resources on an event ([91155c5](91155c5)), closes [jquense#2405](https://github.com/additio/react-big-calendar/issues/2405) [jquense#1649](https://github.com/additio/react-big-calendar/issues/1649)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tabindex, applied to the event div, creates invalid ARIA component nesting
#2498