fix: object bug when nested object has a property with strict (#871)

jquense · May 3, 2020 · 7f52b8a · 7f52b8a
1 parent 95d1401
commit 7f52b8a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/object.js b/src/object.js
@@ -88,7 +88,7 @@ inherits(ObjectSchema, MixedSchema, {
     let innerOptions = {
       ...options,
       parent: intermediateValue,
-      __validating: false,
+      __validating: options.__validating || false,
     };
 
     let isChanged = false;

diff --git a/test/object.js b/test/object.js
@@ -146,6 +146,20 @@ describe('Object types', () => {
       err.message.should.match(/must be a `string` type/);
     });
 
+    it('should respect strict for nested object values', async () => {
+      inst = object({
+        obj: object({
+          field: string().strict(),
+        }),
+      });
+
+      let err = await inst
+        .validate({ obj: { field: 5 } })
+        .should.be.rejected();
+
+      err.message.should.match(/must be a `string` type/);
+    });
+
     it('should respect child schema with strict()', async () => {
       inst = object({
         field: number().strict(),