Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should array schema be skipped when from prop of test context is created? #996

Closed
pipopotamasu opened this issue Aug 1, 2020 · 0 comments · May be fixed by #995
Closed

Should array schema be skipped when from prop of test context is created? #996

pipopotamasu opened this issue Aug 1, 2020 · 0 comments · May be fixed by #995

Comments

@pipopotamasu
Copy link

pipopotamasu commented Aug 1, 2020 •
edited
Loading

I'm really grateful from prop was added by #556.

However, I'm not sure why array schema is skipped although PR says from enable to access parent schema.

https://github.com/jquense/yup/pull/556/files#diff-a39772825a6753e21b910a44bde28402R521-R522

In this test case, I assume this.from[1] should be array schema, not first object schema.

If we should deal with this issue, I would open this PR (currently draft status).
#995
@pipopotamasu pipopotamasu mentioned this issue Aug 1, 2020
Draft
@pipopotamasu pipopotamasu changed the title Should skip array schema when from prop of test context is created? Should array schema be skipped when from prop of test context is created? Aug 1, 2020
@jquense jquense closed this as completed Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add parent access to array schema pipopotamasu/yup
2 participants
@jquense @pipopotamasu