Dialog: missing round corners #4277
Comments
Hi! |
Thanks for setting up this example! You're right in that case it shows correctly. I checked my code to see the difference, and found that I have: <script type="text/template"> -this is underscore js template code-. The updated jsfiddle: |
The problem I want to point out is not so much that this happens with a script element there, it could be any other element: div, span... -surely even hidden element- |
Yes! Now I can see it: http://jsfiddle.net/MauriceG/jKnFQ/2/ |
... and we can do it with the bottom-corners too: http://jsfiddle.net/MauriceG/jKnFQ/5/ |
Thanks @MauriceG, you're a huge help here with triage and fixes. |
When the following page is opened as a dialog (data-rel="dialog"):
the header box is missing its rounded corners at the top.
This is due to the ui-corner-top class being set on the script tag instead of the header.
The code responsible for this is there:
https://github.com/jquery/jquery-mobile/blob/master/js/jquery.mobile.dialog.js#L36
I'm not sure that the class should be set on the first-child element of the dialog..
Shouldn't it be set on the data-role="header" instead or to the data-role="content" itself if no header ?
Same problem with the the bottom and ui-corner-bottom.
This is not a huge problem as I can always move my script code down in the DOM, though it's a strange behaviour.
The text was updated successfully, but these errors were encountered: