Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

transitionPages w/o ajax page loads - Hiding the loader #5036

Closed
JimHapenney opened this issue Sep 19, 2012 · 1 comment
Closed

transitionPages w/o ajax page loads - Hiding the loader #5036

JimHapenney opened this issue Sep 19, 2012 · 1 comment

Comments

@JimHapenney
Copy link

When not using ajax for page loads (i.e. $.mobile.ajaxEnabled = false),
I find it looks better when the loader is is hidden at the completion of an XHR/ajax data request as opposed to the completion of a page transition.

My fix/suggested change:
Starting at line 3352 in jquery.mobile-1.2.0-rc.1.js (internal to function transitionPages())

        //clear page loader - JimHapenny Edit
        if ($.mobile.ajaxEnabled) {
            // deprecated syntax  - $.mobile.hidePageLoadingMsg();
            $.mobile.loading( 'hide' );
        }

Of course this might cause problems elsewhere, so maybe a global config option instead? Or is there a better way to handle this that I'm not seeing?

Also, shouldn't the non-deprecated syntax be used ($.mobile.loading( 'hide' )) to hide the loader?

@jaspermdegroot
Copy link
Contributor

@JimHapenney

Thanks for your post. There is a PR for this feature: #4884. Maybe you can give that a look and comment there.

I am closing this ticket as a feature request. You can add a link to this ticket on the feature request wiki page (https://github.com/jquery/jquery-mobile/wiki/Feature-Requests). Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants