Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Dialog: Tests need to shed backcompat #8247

Open
gabrielschulhof opened this issue Jul 28, 2015 · 1 comment
Open

Dialog: Tests need to shed backcompat #8247

gabrielschulhof opened this issue Jul 28, 2015 · 1 comment

Comments

@gabrielschulhof
Copy link

tests/integration/dialog-extension/index.html must have backcompat turned off, but then toolbars either do not instantiate or instantiate as footers, because they require the enhancer backcompat, which picks up custom initSelector values.

So, we must first land the toolbar review before we can remove the backcompat from these tests.

@gabrielschulhof
Copy link
Author

We must turn off backcompat in the following (non-exhaustive list of) tests after we land toolbar:

  • tests/integration/page/index.html
  • tests/integration/dialog/index.html
  • tests/integration/dialog-extension/index.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants