Modified Plugin.prototype, showing how to add more functions. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugin by extending the prototype of the plugin. I would like to propose a small change to this plugin, showing how to add more functions to this plugin, since the init function, in most cases will not be enough. As I understand it, adding all functions that I want to use to the Plugins prototype is the recommended way of going about it. If I am incorrect I would appreciate feedback about what is the best way to add functions that I want to use in init(). :) Thanks.
|
Hey @kahlil. If you could update your PR against latest I'd be happy to merge. |
|
Ok, will do. Thx. Sent from my iPhone On Tuesday, 1. May 2012 at 17:38, Addy Osmani wrote:
|
|
I am closing this pull request and will create a fresh one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose a small change to this plugin, showing how to add more functions to this plugin, since the init function, in most cases will not be enough. As I understand it, adding all functions that I want to use to the plugin's prototype is the recommended way of going about it. If I am incorrect I would appreciate feedback about what is the best way to add functions that I want to use in init(). :)
Thanks.