Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get jquery-ui file name back #46

Closed
MOZGIII opened this issue Jun 15, 2013 · 3 comments
Closed

Get jquery-ui file name back #46

MOZGIII opened this issue Jun 15, 2013 · 3 comments

Comments

@MOZGIII
Copy link

MOZGIII commented Jun 15, 2013

As long as you can control dependencies via gemspec and jquery-rails does no longer provide jquery-ui file, the upstream name can (and should) now be used.
Consider making an update providing jquery-ui aliased to jquery.ui.all.

@joliss
Copy link
Member

joliss commented Jun 17, 2013

Sounds good. We have a (currently superfluous) dependency on jquery-rails in the gemspec. We should make that dependency to require jquery-rails >= 3.0.0 so we don't collide with 2.x.

I'd love to get a pull request from you. (Add it to the changelog, but don't bump the version please.) Or if you don't get around to it, I'll do it next time I touch this gem.

@joliss
Copy link
Member

joliss commented Oct 13, 2013

I removed the dependency on jquery-rails in #55 because it was causing trouble for people.

If we used jquery-ui.js, we'd still have to ensure jquery-rails < 3.0.0 isn't loaded or we'd conflict with their version. But I don't believe there's a way to disallow "jquery-rails < 3.0.0" in the gemspec without re-adding jquery-rails as a dependency (which I don't want to do).

So as long as jquery-rails 2.x is still floating around, I'm not sure that we can use jquery-ui.js. We could maybe revisit this a year from now though.

@joliss
Copy link
Member

joliss commented Jul 3, 2014

jquery-ui.js has been brought back in #70, released in version 5.0.0. I've added a warning to the README so people know to check for incompatible jquery-rails versions.

@joliss joliss closed this as completed Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants