Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependencies with jQuery 3.4 #2272

Closed
marcwieland95 opened this issue Apr 30, 2019 · 4 comments
Closed

peerDependencies with jQuery 3.4 #2272

marcwieland95 opened this issue Apr 30, 2019 · 4 comments

Comments

@marcwieland95
Copy link

jQuery Validation should also work with the latest jQuery version 3.4, right?

Can we lift the peerDependencies to that version?
NPM audit throws an error because jQuery had some vulnerability prior to that version.

"peerDependencies": {
	"jquery": "^1.7 || ^2.0 || ^3.4"
},
@ericfowler303
Copy link

this has been done in this pull: #2248

This updated code still hasn't been published to the NPM public version so until that's done we'll all keep seeing that error

@marcwieland95
Copy link
Author

Oh man. This project doesn't look that active. But thanks for the pull-request.

I solved it in the meanwhile with this addition in my package.json:

"resolutions": {
    "jquery-validation/jquery": "3.4"
}

@staabm
Copy link
Member

staabm commented Jun 15, 2019

fixed with #2248

@staabm
Copy link
Member

staabm commented Jun 15, 2019

I just published jquery-validateion 1.19.1 to npm.

most important change is that jquery is now defined as a peer dependency, so we dont get into your way. see #2248

sorry this took us so long. jq-validation is not top priority atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants