Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename build-pages task to build-posts? #35

Closed
rdworth opened this issue Mar 31, 2013 · 4 comments
Closed

Rename build-pages task to build-posts? #35

rdworth opened this issue Mar 31, 2013 · 4 comments
Labels
enhancement

Comments

@rdworth
Copy link
Contributor

rdworth commented Mar 31, 2013

All pages are posts but not all posts are pages.
@rdworth
Copy link
Contributor Author

rdworth commented Mar 31, 2013

This is a larger issue than just the name, since this task only puts files into /{wordpress.dir}/posts/page/

@rdworth
Copy link
Contributor Author

rdworth commented Mar 31, 2013

@scottgonzalez thoughts on supporting build of both page and post types of posts each with their own preprocessor without duplicating code?

rdworth referenced this issue in jquery/meetings.jquery.org Mar 31, 2013
@rdworth
Made meeting minutes deploy as wp posts in categories matching team. …
487a08c 
…Depends on a patch to scottgonzalez/node-wordpress to allow post date to be set/updated
@scottgonzalez
Copy link
Member

We could have a build-posts task which handles all posts types. It'd be a multi-task which uses the key as the post type and the value as the file list. The helper would be build-posts-preprocess-{post-type}. We'd need to do some introspection to keep the helpers optional.

Does that sound good?
@ajpiano

@rdworth
Copy link
Contributor Author

rdworth commented Apr 5, 2013

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rdworth @scottgonzalez