Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI #91

Closed
wants to merge 1 commit into from
Closed

Conversation

raphamorim
Copy link
Member

Hi @gnarf, @leobalter
I gave the kickoff for integration. I wonder if can enable jquery-color in travis.

Currently the script only runs grunt, but I'll integrate it with browserstack later.

sudo: false
language: node_js
node_js:
- "0.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might use a newer version here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: b562f60

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to have multiple Node versions, we're not testing anything on Node, maybe the only issue we might have is due to dependencies, but we don't use anything else than devDeps so far.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, so node 5.5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: 228b1dc

@leobalter
Copy link
Member

LGTM.

@leobalter
Copy link
Member

@raphamorim would you squash the commits and set a commit message based on the jQuery Commit guidelines?

You may use Build as the component name.

@leobalter
Copy link
Member

One last thing: it seems you might need to run bower install

@raphamorim
Copy link
Member Author

I'm not sure about it, because jquery-color uses Bowercopy.

Then by default, bowercopy runs bower install.

@gnarf
Copy link
Member

gnarf commented Feb 4, 2016

the current processes here were copied from a REALLLY old version of the
jquery build chain.

everything about it could use "simplifying" probably (including bowercopy,
we can npm jquery now anyway)

On Thu, Feb 4, 2016 at 11:38 AM, Raphael Amorim notifications@github.com
wrote:

I don't know about it, because jquery-color uses Bowercopy
https://www.npmjs.com/package/grunt-bowercopy. Then by default,
bowercopy runs bower install.


Reply to this email directly or view it on GitHub
#91 (comment).

@raphamorim
Copy link
Member Author

I see,

I think it's better merge this PR ( 'cause probably shouldn't change the travis script) and open an issue to discuss the build improvements.

@leobalter
Copy link
Member

I'm ok with the "progressive enhancement".

I just want to turn on Travis CI before I merge this.

@leobalter leobalter closed this in 44cbc46 Feb 16, 2016
@leobalter
Copy link
Member

merged at 44cbc46

👍

@mgol mgol added this to the 3.0.0 milestone May 6, 2020
@mgol mgol added the build label May 6, 2020
@mgol mgol modified the milestones: 3.0.0, 2.2.0 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants