Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Commit

Permalink
property should not be defined in $.mobile.
Browse files Browse the repository at this point in the history
  • Loading branch information
scottjehl committed Feb 3, 2011
1 parent b464b1b commit 6798792
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions js/jquery.mobile.core.js
View file
Expand Up @@ -51,8 +51,6 @@
//configure meta viewport tag's content attr:
metaViewportContent: "width=device-width, minimum-scale=1, maximum-scale=1",

nativeSelectMenus: false,

//support conditions that must be met in order to proceed
gradeA: function(){
return $.support.mediaquery;
Expand Down

5 comments on commit 6798792

@johnbender
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We originally added the ability to designate native selects on a per select basis or on a global bases (the later case is removed above), the above obviously disables the global. Should I remove it from the docs as well?

@scottjehl
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey John,
It can still be set globally, but via the selectmenu plugin's options rather than in the $.mobile hash. You can check out last night's commit, but basically I removed the custom data- additions because we have automated option-to-data-attr support from the widget factory, so a single option should be good enough for both. I updated the docs and unit tests with the changes: http://jquerymobile.com/test/#docs/forms/forms-selects.html

Of course, it's not nearly as concise to set programmatically now, but it's the same as any plugin option this way.

Thanks for chiming in :)

@johnbender
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scott

Brilliant! Altering the option directly on the prototype makes perfect sense, thanks for clarifying.

@johnbender
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scott,

Is the mobile select widget defined when mobileinit is triggered in core? We had to move page before core for this reason.

@johnbender
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed solution:
johnbender/jquery-mobile@f944333...config

Also linked in issue 966
https://github.com/jquery/jquery-mobile/issues/issue/966/#comment_738413

Please sign in to comment.