Permalink
Browse files

Icons: Fixed markup and style guide issues on grunticon demo page

  • Loading branch information...
1 parent 40d4cb8 commit 87453e0a101d5ec2c99b8d4a444fa6970d434147 @jaspermdegroot jaspermdegroot committed Jan 30, 2014
Showing with 28 additions and 27 deletions.
  1. +28 −27 demos/icons-grunticon/index.php
@@ -15,7 +15,6 @@
</script>
<!-- Fall back style sheet incase javascript is turned off -->
<noscript id="grunticon-fallback"><link href="../../css/themes/default/jquery.mobile.fallback.css" rel="stylesheet"></noscript>
- </span>
<link rel="stylesheet" href="http://fonts.googleapis.com/css?family=Open+Sans:300,400,700">
<link rel="stylesheet" href="../../css/themes/default/jquery.mobile.css">
<link rel="stylesheet" href="../_assets/css/jqm-demos.css">
@@ -77,24 +76,26 @@
stylesheet = $( "head" ).find( "link" ).eq( "1" ).attr( "href" ),
svg = /svg/.test( "svg" ),
external = /external/.test( stylesheet ),
- using = ( ( external? "External ":"Inline " ) + ( svg? "SVGs " : "PNGs" ) );
+ using = ( ( external ? "External " : "Inline " ) + ( svg ? "SVGs " : "PNGs" ) );
$( "#grunticon-stylesheet" ).text( stylesheet );
- $( "<span>&nbsp;</span>" ).css({
- "width": "200px",
- "height": "200px",
- "display": "block",
- "background-size": "200px 200px",
- "background-image": svg? "url('data:image/svg+xml;charset=US-ASCII,%3C%3Fxml%20version%3D%221.0%22%20encoding%3D%22iso-8859-1%22%3F%3E%3C!DOCTYPE%20svg%20PUBLIC%20%22-%2F%2FW3C%2F%2FDTD%20SVG%201.1%2F%2FEN%22%20%22http%3A%2F%2Fwww.w3.org%2FGraphics%2FSVG%2F1.1%2FDTD%2Fsvg11.dtd%22%3E%3Csvg%20version%3D%221.1%22%20id%3D%22Layer_1%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20xmlns%3Axlink%3D%22http%3A%2F%2Fwww.w3.org%2F1999%2Fxlink%22%20x%3D%220px%22%20y%3D%220px%22%20%20width%3D%2214px%22%20height%3D%2210px%22%20viewBox%3D%220%200%2014%2010%22%20style%3D%22enable-background%3Anew%200%200%2014%2010%3B%22%20xml%3Aspace%3D%22preserve%22%3E%3Cpath%20fill%3D%22%23FFF%22%20d%3D%22M7%2C0C3%2C0%2C0%2C5%2C0%2C5s3%2C5%2C7%2C5s7-5%2C7-5S11%2C0%2C7%2C0z%20M7%2C8C5.343%2C8%2C4%2C6.657%2C4%2C5s1.343-3%2C3-3s3%2C1.343%2C3%2C3S8.657%2C8%2C7%2C8z%20M7%2C4%20C6.448%2C4%2C6%2C4.447%2C6%2C5s0.448%2C1%2C1%2C1s1-0.447%2C1-1S7.552%2C4%2C7%2C4z%22%2F%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3C%2Fsvg%3E')": "url(../../css/themes/default/images/icons-png/eye-white.png)",
- "background-color": "rgba(0,0,0,.3)"
- })
- .insertAfter("#grunticon-icon-type");
-
- if( !svg ) {
- $("#grunticon-icon-type").after("<p>Pixels make me sad :(</p>");
- } else {
- $("#grunticon-icon-type").after("<p>Woo! Vector graphics!</p>");
- }
+
+ $( "<span>&nbsp;</span>" ).css({
+ "width": "200px",
+ "height": "200px",
+ "display": "block",
+ "background-size": "200px 200px",
+ "background-image": svg ? "url('data:image/svg+xml;charset=US-ASCII,%3C%3Fxml%20version%3D%221.0%22%20encoding%3D%22iso-8859-1%22%3F%3E%3C!DOCTYPE%20svg%20PUBLIC%20%22-%2F%2FW3C%2F%2FDTD%20SVG%201.1%2F%2FEN%22%20%22http%3A%2F%2Fwww.w3.org%2FGraphics%2FSVG%2F1.1%2FDTD%2Fsvg11.dtd%22%3E%3Csvg%20version%3D%221.1%22%20id%3D%22Layer_1%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20xmlns%3Axlink%3D%22http%3A%2F%2Fwww.w3.org%2F1999%2Fxlink%22%20x%3D%220px%22%20y%3D%220px%22%20%20width%3D%2214px%22%20height%3D%2210px%22%20viewBox%3D%220%200%2014%2010%22%20style%3D%22enable-background%3Anew%200%200%2014%2010%3B%22%20xml%3Aspace%3D%22preserve%22%3E%3Cpath%20fill%3D%22%23FFF%22%20d%3D%22M7%2C0C3%2C0%2C0%2C5%2C0%2C5s3%2C5%2C7%2C5s7-5%2C7-5S11%2C0%2C7%2C0z%20M7%2C8C5.343%2C8%2C4%2C6.657%2C4%2C5s1.343-3%2C3-3s3%2C1.343%2C3%2C3S8.657%2C8%2C7%2C8z%20M7%2C4%20C6.448%2C4%2C6%2C4.447%2C6%2C5s0.448%2C1%2C1%2C1s1-0.447%2C1-1S7.552%2C4%2C7%2C4z%22%2F%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3Cg%3E%3C%2Fg%3E%3C%2Fsvg%3E')" : "url(../../css/themes/default/images/icons-png/eye-white.png)",
+ "background-color": "rgba(0,0,0,.3)"
+ })
+ .insertAfter("#grunticon-icon-type");
+
+ if ( !svg ) {
+ $( "#grunticon-icon-type" ).after( "<p>Pixels make me sad :(</p>" );
+ } else {
+ $( "#grunticon-icon-type" ).after( "<p>Woo! Vector graphics!</p>" );
+ }
+
$( "#grunticon-icon-type" ).text( using );
});
</script>
@@ -123,7 +124,7 @@
<span data-demo-js="#grunticon-loader"></span>
- <p>After this script you will want to place a fallback style sheet in a noscript tag, in case javascript is disabled. Link in the "View Source" button below:</p>
+ <p>After this script you will want to place a fallback style sheet in a noscript tag, in case JavaScript is disabled. Link in the "View Source" button below:</p>
<span data-demo-html="#grunticon-fallback"></span>
@@ -216,20 +217,20 @@
<button class="ui-btn ui-shadow ui-corner-all ui-btn-icon-left ui-icon-tag">tag</button>
<button class="ui-btn ui-shadow ui-corner-all ui-btn-icon-left ui-icon-user">user</button>
<button class="ui-btn ui-shadow ui-corner-all ui-btn-icon-left ui-icon-video">video</button>
- <button class="ui-btn ui-shadow ui-corner-all ui-btn-icon-left ui-icon-alert">alert</button>
- <button class="ui-btn ui-shadow ui-corner-all ui-btn-icon-left ui-icon-delete">delete</button>
+ </form>
</div>
- </div><!-- /content -->
+ </div><!-- /content -->
- <?php include( '../jqm-navmenu.php' ); ?>
+ <?php include( '../jqm-navmenu.php' ); ?>
- <div data-role="footer" data-position="fixed" data-tap-toggle="false" class="jqm-footer">
- <p>jQuery Mobile Demos version <span class="jqm-version"></span></p>
- <p>Copyright 2014 The jQuery Foundation</p>
- </div><!-- /footer -->
+ <div data-role="footer" data-position="fixed" data-tap-toggle="false" class="jqm-footer">
+ <p>jQuery Mobile Demos version <span class="jqm-version"></span></p>
+ <p>Copyright 2014 The jQuery Foundation</p>
+ </div><!-- /footer -->
- <?php include( '../jqm-search.php' ); ?>
+ <?php include( '../jqm-search.php' ); ?>
+ </div><!-- /page -->
</body>
</html>

0 comments on commit 87453e0

Please sign in to comment.