Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Mixing "text" and "notext" buttons in controlgroup #2484

Closed
waylan opened this issue Sep 20, 2011 · 4 comments
Closed

Mixing "text" and "notext" buttons in controlgroup #2484

waylan opened this issue Sep 20, 2011 · 4 comments

Comments

@waylan
Copy link

waylan commented Sep 20, 2011

Given the following markup I expected the buttons to all be sized with the same proportions:

<div data-role="controlgroup" data-type="horizontal">
    <a id="back" data-role="button" data-icon="arrow-l" data-iconpos="notext"</a>
    <a id="text" data-role="button">Some text</a>
    <a id="forward" data-role="button" data-icon="arrow-r" data-iconpos="notext"></a>
</div>

Instead, the "notext" buttons are only about two-thirds the height of the "text" button - which looks ridiculous to say the least.

As a work-around I was able to do this:

<div data-role="controlgroup" data-type="horizontal">
    <a id="back" data-role="button" data-icon="arrow-l">&nbsp;</a>
    <a id="text" data-role="button">Some text</a>
    <a id="forward" data-role="button" data-icon="arrow-r" data-iconpos="right">&nbsp;</a>
</div>

But it feels hacky and leaves extra spaces in what should be "notext" buttons. In fact, if the "notext" buttons are not on the ends, there is no way to make this work with proper spacing (the icon would need to be between 2 non-braking spaces - uhg).

Having done some searching, this may or may-not be related to issue #1998.

@toddparker
Copy link
Contributor

I see. We had conceived of the notext version as a small, round icon button like you see on a splitview, not as a large button but I can see a place for both types. We'll consider adding this as a new type post 1.0. Can you add this request to the feature request wiki page, then close this issue (we'll re-open when we add this).

_t

@waylan
Copy link
Author

waylan commented Sep 22, 2011

Added to Feature Requests. Thanks.

@waylan waylan closed this as completed Sep 22, 2011
@toddparker
Copy link
Contributor

Excellent, thanks!

@jaspermdegroot
Copy link
Contributor

@waylan - This change landed in master (latest code) and will be part of 1.2.. I will remove the request from the wiki page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants