Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Commit @0f81773 seems to degrade text inputs on FF, IE #2842

Closed
plievone opened this issue Oct 25, 2011 · 6 comments
Closed

Commit @0f81773 seems to degrade text inputs on FF, IE #2842

plievone opened this issue Oct 25, 2011 · 6 comments
Assignees
Milestone

Comments

@plievone
Copy link

Examples in http://jquerymobile.com/test/docs/forms/textinputs/ have no padding in FF and IE. Chrome works ok. It seems that couple of padding: .4em 1.5%; in https://github.com/jquery/jquery-mobile/blob/master/css/structure/jquery.mobile.forms.textinput.css do not work properly. One of the rules was added around commit @0f81773. As a workaround I use padding: .4em in my stylesheets until this regression is fixed.

@johnbender
Copy link
Contributor

@plievone

Thanks for submitting. We'll take a look.

@ghost ghost assigned Wilto Oct 25, 2011
@toddparker
Copy link
Contributor

Looks like this rule to set horizontal padding isn't working in FF/IE:

input.ui-input-text, textarea.ui-input-text { background-image: none; padding: .4em 1.5%; line-height: 1.4; font-size: 16px; display: block; width: 97%; }

I was an even .4em and that commit added the 1.5% left/right padding rule. Just want to confirm why this was added by @Wilto before changing it.

@Wilto Wilto closed this as completed in b4a3641 Oct 26, 2011
@Wilto
Copy link
Contributor

Wilto commented Oct 26, 2011

Totally my bad on this—the percentage-based padding was to account for the width: 97% I added to ensure that textareas/text inputs outside of a fieldcontain span the full available width. A static .4em padding all around seems small enough that it doesn’t really throw things off.

@plievone
Copy link
Author

Thanks for quick fix. However, there still exists another rule for hidden labels with the same issue

.ui-hide-label input.ui-input-text, 
    .ui-hide-label textarea.ui-input-text, 
    .ui-hide-label .ui-input-search { padding: .4em 1.5%; width: 97%; }

For example, see the first field in http://jquerymobile.com/test/docs/forms/docs-forms.html

Wilto added a commit that referenced this issue Oct 27, 2011
…e to hidden labels no longer rely on percentage-based left/right padding.
@plievone
Copy link
Author

Thanks, and here's a link to Firefox bug tracker if somebody wants to follow this further:
"Bug 527459 - Padding specified in percent ignored on text inputs"
https://bugzilla.mozilla.org/show_bug.cgi?id=527459

@toddparker
Copy link
Contributor

Thanks for the link to that issue. Seems like it has a lot of people's attention.

timmywil pushed a commit to timmywil/jquery-mobile that referenced this issue Nov 5, 2011
…ercentage-based textarea/text input padding is ignored in Firefox. Current Firefox. In 2011. Submitted with comment.
timmywil pushed a commit to timmywil/jquery-mobile that referenced this issue Nov 5, 2011
…rm elements due to hidden labels no longer rely on percentage-based left/right padding.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants