This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Issue #4535: Modified click handler to remove the call to window.history... #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory.back() which was contributing to jumpiness (especially noticeable on Android) and used urlHistory instead. Also updated a line of code in jquery.mobile.transition.js to retrieve the toPageScrollTo that's passed along. Also updated the test for popup_core.js since there was one test failing which was not related to my changes, and only seemed to be a timing issue since changing line 368 to have a timeout length of 700 instead of 600 allowed the test to pass.
|
Sorry, I just noticed that two of the variable names I used for debugging go against the standard coding style. I'll fix and submit a new pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....back() which was contributing to jumpiness of transitions (especially noticeable on Android) and used urlHistory instead (see issue #4535 for more info). Also updated a line of code in jquery.mobile.transition.js to retrieve the toPageScrollTo that's passed along. Also updated the test for popup_core.js since there was one test failing which was not related to my changes, and only seemed to be a timing issue since changing line 368 to have a timeout length of 700 instead of 600 allowed the test to pass.