New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard does not disappear when after the pop-up is closed #5974

Closed
newrachael opened this Issue May 7, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@newrachael

Issue description

  • keyboard ( in iPhone ) dose not disappear, when popup is closed.

Test page (see below)

Steps to reproduce

    1. Click the sign in button ( form )
    2. Click the username text box
    3. Click the outside of pop-up

Expected outcome

  • keyboard will be disappear.

Actual outcome

  • keyboard does not disappear

Platforms/browsers (including version) and devices tested

  • iPhone5. Android 4.1 (Galaxy note )

jquery-mobile / js / widgets / popup.js

671line
_close: function( immediate ) {
this._ui.container.removeClass( "ui-popup-active" );
this._page.removeClass( "ui-popup-open" );

            // after 
            input elements in container have to call "blur"

gabrielschulhof added a commit that referenced this issue May 7, 2013

Tests: Integration: Popup: Add test to make sure popup elements do no…
…t have focus after the popup is closed. Tests #5974.
@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 7, 2013

Contributor

@newrachael, could you please verify that the keyboard disappears when you follow the steps you listed on the page below?

http://view.jquerymobile.com/master/dist/demos/widgets/popup/

Contributor

gabrielschulhof commented May 7, 2013

@newrachael, could you please verify that the keyboard disappears when you follow the steps you listed on the page below?

http://view.jquerymobile.com/master/dist/demos/widgets/popup/

gabrielschulhof added a commit that referenced this issue May 7, 2013

Tests: Integration: Popup: Add test to make sure popup elements do no…
…t have focus after the popup is closed. Tests #5974. (applied by hand from 273624b)

gabrielschulhof added a commit that referenced this issue May 7, 2013

Popup: Blur any focused elements inside container, including the cont…
…ainer itself, upon closing. Fixes #5974 - keyboard does not disappear when after the pop-up is closed.

(cherry picked from commit 4659c97)

Conflicts:
	js/widgets/popup.js
@newrachael

This comment has been minimized.

Show comment
Hide comment
@newrachael

newrachael May 8, 2013

@gabrielschulhof

Thank you for your quick response. This issue has been fixed ( keyboard disappears when pop-up is closed )

@gabrielschulhof

Thank you for your quick response. This issue has been fixed ( keyboard disappears when pop-up is closed )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment