Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Controlgroup horizontal in Field container on very narrow < 28em screens is shown as vertical. #7337

Closed
slavap opened this issue Apr 23, 2014 · 5 comments

Comments

@slavap
Copy link

slavap commented Apr 23, 2014

This bug can be fixed by the following CSS:

@media (max-width: 27.95em) {
  .ui-field-contain .ui-controlgroup-horizontal .ui-controlgroup-controls {
    display: block;
  }
}
@jaspermdegroot
Copy link
Contributor

@slavap

Thanks for reporting the issue. Can you please provide a simple test case that illustrates the problem. See the contributing guidelines for our JS Bin template and instructions. Thanks!

@slavap
Copy link
Author

slavap commented Apr 25, 2014

Test case: http://jsbin.com/acIRUBo/57/edit

@gabrielschulhof
Copy link

Removing incomplete status.

TBH, I'm not sure whether it's better to switch to vertical mode right away, which is what happens with the CSS commented out, or whether it's better to retain horizontal mode for as long as possible and then gradually wrap each button. I'm inclined to prefer the way things are now, where the controlgroup turns entirely vertical below the threshold. We do, however, need to fix the borders, from the looks of things.

@slavap
Copy link
Author

slavap commented Apr 30, 2014

Of course it's better to retain horizontal mode for as long as possible (based on content actually, but it's hard to achieve with CSS only). Behavior when the controlgroup turns entirely vertical below the threshold is quite bad solution, at least it must be possible to control threshold with attributes or classes.

@arschmitz
Copy link
Contributor

The controlgroup widget is being replaced by ui one in 1.5 im closing this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants