This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Navigation: Add demo showing how to copy script references and widgets #7370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the demo link from view: http://view.jquerymobile.com/7362-ajax-with-external-widgets-demo/demos/navigation-ajax-external-widgets/ |
This was referenced May 6, 2014
|
This looks good to me. I would only move the menu button to the left and use a text button with "navigate" in it. @arschmitz can you give the demo a look as well? |
|
@gabrielschulhof you should look at the the optimized toolbar demos and these should be combined or at least reference each other in some way http://demos.jquerymobile.com/1.4.2/toolbar-fixed-persistent-optimized/ |
|
@gabrielschulhof is this ready to review again? |
|
@arschmitz no, not yet. |
gabrielschulhof
added
Action: PR needs modification
and removed
Action: PR needs reviewing
labels
gabrielschulhof
force-pushed
the
7362-ajax-with-external-widgets-demo
branch
from
55ce9a9
to
89916b7
Compare
added 15 commits
December 29, 2014 15:38
Turn it into a generic demo showing external widgets.
We have to do this because the popup now attaches to the body
gabrielschulhof
force-pushed
the
7362-ajax-with-external-widgets-demo
branch
from
bbcffcd
to
bb24684
Compare
gabrielschulhof
force-pushed
the
7362-ajax-with-external-widgets-demo
branch
from
bb24684
to
664f79d
Compare
|
@gabrielschulhof Is this PR ready to review again? |
|
@arschmitz Yes it is, absolutely. |
|
👍 |
kapilgarg1996
pushed a commit
to kapilgarg1996/jquery-mobile
that referenced
this pull request
Jun 27, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7362