data-role="none" buttons still enhanced when used in controlgroup #7676

Closed
adammessinger opened this Issue Sep 17, 2014 · 3 comments

Projects

None yet

3 participants

@adammessinger

My current project has a pagination control that includes a "self-submitting" select menu of pages and next/previous links. There's also a submit button with data-role="none" that's hidden if jQuery Mobile has enhanced the page. This is added so people without JS or using old browsers like IE 7 that jQM doesn't support can still submit the form to choose a page.

The data-role="none" button is still enhanced, despite being excluded using that data attribute. This is throwing off the formatting of the pagination control a bit on the last page. Demo/test page: http://jsbin.com/misihuqotunu/1/

For now, I'm getting around this by giving the next/prev links a class of "ui-state-disabled" on the first and last pages rather than excluding them.

@gabrielschulhof
Contributor

You can fix this by using class ui-screen-hidden instead of jqm-hidden. When the controlgroup is instantiated, it attempts to determine the last visible button, but it cannot rely on the :visible selector, because the page itself is not yet visible, so all its elements are hidden. Thus, it falls back to checking for the presence of class ui-screen-hidden.

@gabrielschulhof
Contributor

I'm still investigating why the button gets enhanced, though, because we should be filtering things that are supposed to stay native.

@gabrielschulhof gabrielschulhof added this to the 1.4.5 milestone Sep 18, 2014
@gabrielschulhof gabrielschulhof self-assigned this Sep 18, 2014
@gabrielschulhof
Contributor

Oh, but we're not filtering buttonMarkup() :/

@jaspermdegroot jaspermdegroot modified the milestone: 1.4.5, 1.5.0 Sep 18, 2014
@gabrielschulhof gabrielschulhof modified the milestone: 1.4.5, 1.5.0 Sep 23, 2014
@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@gabrielschulhof @agcolom gabrielschulhof + agcolom Controlgroup: Honor keepNative even for buttonMarkup()
Closes gh-7683
Fixes gh-7676
75f92e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment