This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Navigation: Remove $.mobile.changePage and $.mobile.loadPage #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,7 +133,10 @@ | |||
| home: function() { | |||
|
|
|||
| // Programatically changes to the categories page | |||
| $.mobile.changePage( "#categories" , { reverse: false, changeHash: false } ); | |||
| $.mobile.pageContainer.pagecontainer( "change", "#categories" , { | |||
There was a problem hiding this comment.
$.mobile.pageContainer is deprecated
|
I stopped commenting on the uses of |
gabrielschulhof
added
Action: PR needs modification
and removed
Action: PR needs reviewing
labels
gabrielschulhof
added
Action: PR needs reviewing
and removed
Action: PR needs modification
labels
1 similar comment
gabrielschulhof
added
Action: PR needs modification
and removed
Action: PR needs reviewing
labels
gabrielschulhof
force-pushed
the
7946-remove-changePage
branch
from
460d914
to
9798521
Compare
gabrielschulhof
force-pushed
the
7946-remove-changePage
branch
from
a8e7d92
to
4f200c4
Compare
gabrielschulhof
added
Action: PR needs reviewing
and removed
Action: PR needs modification
labels
|
@gabrielschulhof it looks like you introduced |
arschmitz
added
Action: PR needs modification
and removed
Action: PR needs reviewing
labels
|
@arschmitz I'm not sure how I would go about using it. Should I always just access |
gabrielschulhof
added
Action: PR needs discussion
and removed
Action: PR needs modification
labels
|
@gabrielschulhof yes thats exactly what you should do. maybe add a support comment anywhere we will need to update to support multiple to make it easy to find |
gabrielschulhof
added
Action: PR needs modification
and removed
Action: PR needs discussion
labels
Closed
|
replaced by #8261 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-6691
Fixes gh-7946