Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1338 #1710

Merged
merged 5 commits into from Jun 24, 2011

Conversation

Projects
None yet
3 participants
@gseguin
Copy link
Member

gseguin commented May 25, 2011

Fix and unit test

Ghislain Seguin and others added some commits May 25, 2011

Ghislain Seguin
Issue #1338
Fixed CSS
Fix for issue 1708 - nightbuild close dialog throwing error
- Check the returned active object to see if it is valid before attempting to extract the transition out of it. Default to $.mobile.defaultDialogTransition if there is no active object.
Ghislain Seguin
Issue #1338
Smaller CSS fix
Ghislain Seguin
Issue #1338
Added unit test
@scottjehl

This comment has been minimized.

Copy link
Contributor

scottjehl commented Jun 24, 2011

Is this still an issue?

@gseguin gseguin closed this Jun 24, 2011

@gseguin

This comment has been minimized.

Copy link
Member Author

gseguin commented Jun 24, 2011

I believe so, check http://jsbin.com/isizo5/6

@gseguin gseguin reopened this Jun 24, 2011

@scottjehl

This comment has been minimized.

Copy link
Contributor

scottjehl commented Jun 24, 2011

just tested, looking good. Thanks!

scottjehl pushed a commit that referenced this pull request Jun 24, 2011

@scottjehl scottjehl merged commit e8a973f into jquery:master Jun 24, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.