Support transparent dialog backgrounds #2380

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
7 participants
@tqc

tqc commented Sep 2, 2011

This change allows the dialog to work more like a standard dialog when the device screen is significantly larger than the dialog content.

When transitioning to a dialog, the class ui-dialog-background is added to the previous page so that it will remain visible if the background of ui-dialog is set to transparent rather than black.

The background page may also need data-dom-cache set to prevent it from being removed - there doesn't seem to be an easy way around that without significantly complicating the timer call that removes hidden pages.

@kilrogg

This comment has been minimized.

Show comment
Hide comment
@kilrogg

kilrogg Sep 16, 2011

+1

please add!

+1

please add!

@tqc

This comment has been minimized.

Show comment
Hide comment
@tqc

tqc Sep 20, 2011

Additional change unrelated to the original pull request - add swipeup/swipedown events and add a data parameter to the swipe event trigger so that multitouch gestures can be detected and handled differently if necessary.

tqc commented Sep 20, 2011

Additional change unrelated to the original pull request - add swipeup/swipedown events and add a data parameter to the swipe event trigger so that multitouch gestures can be detected and handled differently if necessary.

@tqc tqc closed this Sep 20, 2011

@tqc tqc reopened this Sep 20, 2011

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Sep 21, 2011

Contributor

Great idea. Added to the feature requests page https://github.com/jquery/jquery-mobile/wiki/Feature-Requests

Contributor

scottjehl commented Sep 21, 2011

Great idea. Added to the feature requests page https://github.com/jquery/jquery-mobile/wiki/Feature-Requests

@scottjehl scottjehl closed this Sep 21, 2011

@skang

This comment has been minimized.

Show comment
Hide comment
@skang

skang Mar 8, 2012

Absolutely agree!!! Some users find it quite annoying (even angering) to be deprived of the context page view when a dialog shows up with empty background.

skang commented Mar 8, 2012

Absolutely agree!!! Some users find it quite annoying (even angering) to be deprived of the context page view when a dialog shows up with empty background.

@xmkevin

This comment has been minimized.

Show comment
Hide comment
@xmkevin

xmkevin Apr 18, 2012

Yes, this is what we want. but he latest release is not support it.

xmkevin commented Apr 18, 2012

Yes, this is what we want. but he latest release is not support it.

@tqc

This comment has been minimized.

Show comment
Hide comment
@tqc

tqc Apr 19, 2012

I'm now using a modified version of this which doesn't require modifying jquery mobile itself:

http://tqcblog.com/2012/04/19/transparent-jquery-mobile-dialogs/

tqc commented Apr 19, 2012

I'm now using a modified version of this which doesn't require modifying jquery mobile itself:

http://tqcblog.com/2012/04/19/transparent-jquery-mobile-dialogs/

@serbanghita

This comment has been minimized.

Show comment
Hide comment
@serbanghita

serbanghita Jun 27, 2012

Hello,

Why is this closed, is is available in a dev release?

Hello,

Why is this closed, is is available in a dev release?

@marceloverdijk

This comment has been minimized.

Show comment
Hide comment
@marceloverdijk

marceloverdijk Jul 18, 2012

Also wonder if this is implemented or not. I'm using 1.1.1 but can't find anything in the docs related to transparent dialogs...

Also wonder if this is implemented or not. I'm using 1.1.1 but can't find anything in the docs related to transparent dialogs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment