This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Fixes #4895 - 1px jitter on fixed toolbars #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking forward to this fix |
…toolbars (tapToggle) to prevent vertical scrollbar on desktop browsers.
|
Committed fix for the 1px shift of the content as well. |
|
While testing this on Android 4.1 native browser the header disappeared on tapToggle if the page wasn't scrolled :( |
|
@arschmitz tested this as well on Android Jelly Bean native browser and and we can't reproduce the problem with the disappearing header anymore. Merging. |
jaspermdegroot
added a commit
that referenced
this pull request
Oct 15, 2012
Fixes #4895 - 1px jitter on fixed toolbars
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only thing that this isn't fixed yet by this PR is that the content shifts 1px on tapToggle, because of updatePagePadding.