Table: Copy entire contents of reflow headers into reflow bold tags #7437

gabrielschulhof · 2014-05-27T20:13:31Z

coveralls · 2014-05-30T20:25:13Z

Coverage increased (+0.05%) when pulling b6b5630 on 7415-copy-reflow-header into 039c0b6 on master.

arschmitz · 2014-06-02T17:44:17Z

tests/unit/table/table_core.js

+									.eq( 1 )
+										.children( "b" )
+											.children( "span.make-it-red" )
+												.length,


I think this might be a little indentation happy :)

... and yet http://contribute.jquery.org/style-guide/js/#chained-method-calls

I suppose I can replace that traversal with a selector ...

coveralls · 2014-06-02T19:55:16Z

Coverage increased (+0.03%) when pulling e1e6651 on 7415-copy-reflow-header into 039c0b6 on master.

arschmitz · 2014-06-05T15:56:49Z

tests/unit/table/table_core.js

+						.eq( 1 )
+							.children( "b" )
+								.children( "span.make-it-red" )
+									.length,


#reflow-table-test .ui-table-reflow > tbody span.make-it-red can replace this all the test table has only one tr and only one th has the span to copy

arschmitz · 2014-06-05T19:34:29Z

👍

coveralls · 2014-06-05T20:05:09Z

Coverage increased (+0.15%) when pulling 45e92b2 on 7415-copy-reflow-header into 039c0b6 on master.

(cherry picked from commit a9472ce) Closes gh-7437 Fixes gh-7415

Closes jquery-archivegh-7437 Fixes jquery-archivegh-7415

Gabriel Schulhof added 2 commits May 27, 2014 23:11

Table: Copy entire contents of reflow headers into reflow bold tags

289950b

Fixes gh-7415

Table: Test that all contents is copied into the bold tags

b6b5630

gabrielschulhof added the Component: Table label May 27, 2014

gabrielschulhof added this to the 1.4.3 milestone May 27, 2014

gabrielschulhof assigned arschmitz May 27, 2014

jaspermdegroot added the Action: PR needs reviewing label Jun 2, 2014

arschmitz reviewed Jun 2, 2014
View reviewed changes

Table: Replace part of a long sequence of method chains with a selector

e1e6651

arschmitz reviewed Jun 5, 2014
View reviewed changes

Table: Simplify selector

45e92b2

arschmitz removed the Action: PR needs reviewing label Jun 6, 2014

gabrielschulhof closed this in a9472ce Jun 6, 2014

gabrielschulhof pushed a commit that referenced this pull request Jun 6, 2014

Table: Copy entire contents of reflow headers into reflow bold tags

14d2343

(cherry picked from commit a9472ce) Closes gh-7437 Fixes gh-7415

gabrielschulhof deleted the 7415-copy-reflow-header branch June 6, 2014 05:09

agcolom pushed a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014

Table: Copy entire contents of reflow headers into reflow bold tags

35a88f7

Closes jquery-archivegh-7437 Fixes jquery-archivegh-7415

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Table: Copy entire contents of reflow headers into reflow bold tags #7437

Table: Copy entire contents of reflow headers into reflow bold tags #7437

gabrielschulhof commented May 27, 2014

coveralls commented May 30, 2014

arschmitz Jun 2, 2014

gabrielschulhof Jun 2, 2014

gabrielschulhof Jun 2, 2014

coveralls commented Jun 2, 2014

arschmitz Jun 5, 2014

arschmitz commented Jun 5, 2014

coveralls commented Jun 5, 2014

Table: Copy entire contents of reflow headers into reflow bold tags #7437

Table: Copy entire contents of reflow headers into reflow bold tags #7437

Conversation

gabrielschulhof commented May 27, 2014

coveralls commented May 30, 2014

arschmitz Jun 2, 2014

Choose a reason for hiding this comment

gabrielschulhof Jun 2, 2014

Choose a reason for hiding this comment

gabrielschulhof Jun 2, 2014

Choose a reason for hiding this comment

coveralls commented Jun 2, 2014

arschmitz Jun 5, 2014

Choose a reason for hiding this comment

arschmitz commented Jun 5, 2014

coveralls commented Jun 5, 2014