Table: Copy entire contents of reflow headers into reflow bold tags #7437

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

gabrielschulhof commented May 27, 2014

Fixes gh-7415

gabrielschulhof added this to the 1.4.3 milestone May 27, 2014

Coverage Status

Coverage increased (+0.05%) when pulling b6b5630 on 7415-copy-reflow-header into 039c0b6 on master.

@arschmitz arschmitz and 1 other commented on an outdated diff Jun 2, 2014

tests/unit/table/table_core.js
@@ -92,6 +92,17 @@
asyncTest( "The page should be enhanced correctly" , function(){
setTimeout(function() {
ok($('#reflow-table-test .ui-table-reflow').length, ".ui-table-reflow class added to table element");
+ deepEqual(
+ $('#reflow-table-test .ui-table-reflow')
+ .children( "tbody" )
+ .children( "tr" )
+ .first()
+ .children()
+ .eq( 1 )
+ .children( "b" )
+ .children( "span.make-it-red" )
+ .length,
@arschmitz

arschmitz Jun 2, 2014

Owner

I think this might be a little indentation happy :)

@gabrielschulhof

gabrielschulhof Jun 2, 2014

Contributor

I suppose I can replace that traversal with a selector ...

Coverage Status

Coverage increased (+0.03%) when pulling e1e6651 on 7415-copy-reflow-header into 039c0b6 on master.

@arschmitz arschmitz commented on an outdated diff Jun 5, 2014

tests/unit/table/table_core.js
@@ -92,6 +92,14 @@
asyncTest( "The page should be enhanced correctly" , function(){
setTimeout(function() {
ok($('#reflow-table-test .ui-table-reflow').length, ".ui-table-reflow class added to table element");
+ deepEqual(
+ $( "#reflow-table-test .ui-table-reflow > tbody > tr:first-child" )
+ .children()
+ .eq( 1 )
+ .children( "b" )
+ .children( "span.make-it-red" )
+ .length,
@arschmitz

arschmitz Jun 5, 2014

Owner

#reflow-table-test .ui-table-reflow > tbody span.make-it-red can replace this all the test table has only one tr and only one th has the span to copy

Owner

arschmitz commented Jun 5, 2014

👍

Coverage Status

Coverage increased (+0.15%) when pulling 45e92b2 on 7415-copy-reflow-header into 039c0b6 on master.

@gabrielschulhof gabrielschulhof added a commit that referenced this pull request Jun 6, 2014

@gabrielschulhof gabrielschulhof Table: Copy entire contents of reflow headers into reflow bold tags
(cherry picked from commit a9472ce)

Closes gh-7437
Fixes gh-7415
14d2343

gabrielschulhof deleted the 7415-copy-reflow-header branch Jun 6, 2014

@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014

@gabrielschulhof @agcolom gabrielschulhof + agcolom Table: Copy entire contents of reflow headers into reflow bold tags
Closes gh-7437
Fixes gh-7415
35a88f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment