This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Build: Include events.js from jquery.mobile.js #7926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
events.js was making it into the build only by virtue of the fact that it was being pulled by navigation.js. In the process of fixing jquery-archivegh-7805 it became clear that navigation.js doesn't really need events.js. Thus, the reference to events.js was removed from navigation.js, thereby orphaning events.js from the build. This rectifies the problem by explicitly adding events.js to the build. Fixes jquery-archivegh-7925
|
I don't think we need to test this and if we are going to we need to verify not just this but that the build has al the proper modules and in the proper order. |
arschmitz
added
Action: PR needs discussion
and removed
Action: PR needs reviewing
labels
|
@arschmitz I definitely think we should have a test for making sure the library gets built properly. Do you want me to add the rest of the library? I'm not sure if I can test the order of things, but I can certainly test whether all the things are present. |
|
OK. After discussing, we'll wait for UI's solution to testing that the build is correct. I'll remove the test. |
gabrielschulhof
force-pushed
the
7925-events-not-included-in-build
branch
from
b447633
to
392f394
Compare
gabrielschulhof
added
Action: PR needs reviewing
and removed
Action: PR needs discussion
labels
|
👍 |
kakul
pushed a commit
to kakul/jquery-mobile
that referenced
this pull request
Apr 14, 2015
events.js was making it into the build only by virtue of the fact that it was being pulled by navigation.js. In the process of fixing jquery-archivegh-7805 it became clear that navigation.js doesn't really need events.js. Thus, the reference to events.js was removed from navigation.js, thereby orphaning events.js from the build. This rectifies the problem by explicitly adding events.js to the build. Fixes jquery-archivegh-7925 Closes jquery-archivegh-7926
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
events.js was making it into the build only by virtue of the fact that it was
being pulled by navigation.js. In the process of fixing gh-7805 it became clear
that navigation.js doesn't really need events.js. Thus, the reference to
events.js was removed from navigation.js, thereby orphaning events.js from the
build. This rectifies the problem by explicitly adding events.js to the build.
Fixes gh-7925