Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Demos: Fixed last row styling for lower resolutions #8073

Closed
wants to merge 2 commits into from

Conversation

kakul
Copy link
Contributor

@kakul kakul commented Apr 14, 2015

Fixes gh-7954

@arschmitz
Copy link
Contributor

@jaspermdegroot want to take a look at this?

@arschmitz arschmitz added this to the 1.5.0 milestone Apr 14, 2015
@jaspermdegroot
Copy link
Contributor

@arschmitz - Sure, will do.

@jaspermdegroot
Copy link
Contributor

@kakul

Thanks for the PR.

The idea was to give the last row a bit darker border bottom. Instead of removing those styles for the last row we could wrap them in a media query to make them only apply on wider screens, but I think it looks good enough without them so I am fine with removing it.

On small screens the last table row looks still a bit different than the others. This can be fixed by removing the .movie-list tbody tr:last-child selector from the first rule. Can you make that change?

@kakul
Copy link
Contributor Author

kakul commented Apr 17, 2015

Hello @jaspermdegroot
Thanks for your review. I have made the change as you proposed.

@jaspermdegroot
Copy link
Contributor

@kakul - Thanks!

@arschmitz - This can be merged in master.

@arschmitz
Copy link
Contributor

@jaspermdegroot thank you
@kakul will merge this shortly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demos: Reflow table, last entry without stripes
4 participants