Navbar: Implement Classes Option #8297
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
cgack
force-pushed
the
7705-navbar-classes-option
branch
from
e51abcb
to
c2a049d
Compare
|
@arschmitz ready for review when you get a chance |
| if ( $.mobileBackcompat !== false ) { | ||
| return $.widget( "mobile.navbar", $.mobile.navbar, { | ||
| _create: function() { | ||
| var self = this; |
There was a problem hiding this comment.
Don't use self this break in some contexts self has special meaning window.self === window instead use var that = this;
|
@arschmitz I made some changes. ready for another round when you get a chance |
|
Sorry to interject, but will this prevent jQM from inserting classes into my navbar elements such as |
|
@dt1973 can you open an issue explaining your issue with a jsbin example and we will be happy to take a look and consider this case. |
| that.navButtons = navButtons; | ||
| that.numButtons = numButtons; | ||
| that.maxButton = maxButton; | ||
| that.iconpos = iconpos; |
fix styling for more button Fixes jquery-archivegh-7705
merge with latest toolbar Fixes jquery-archivegh-7705
jscs Fixes jquery-archivegh-7705
added backcompat tests and classes Fixes jquery-archivegh-7705
hasClasses and lacksClasses in tests Fixes jquery-archivegh-7705
remove onevar Fixes jquery-archivegh-7705
split out var statements Fixes jquery-archivegh-7705
remove deprecated jqmEnhanceable Fixes jquery-archivegh-7705
replace self with that Fixes jquery-archivegh-7705
fix glyphish example Fixes jquery-archivegh-7705
review changes Fixes jquery-archivegh-7705
style cleanup Fixes jquery-archivegh-7705
make backcompat tests work Fixes jquery-archivegh-7705
remove hungarian Fixes jquery-archivegh-7705
morebutton should be a button Fixes jquery-archivegh-7705
cgack
force-pushed
the
7705-navbar-classes-option
branch
from
dc3f5d3
to
6da2904
Compare
|
Closing with f3bd7c4 landing on 1.5-dev |
This includes the new navbar widget from the navbar review branch.