Skip to content

Commit

Permalink
Autocomplete: Don't react to key events on readonly inputs. Fixes #61…
Browse files Browse the repository at this point in the history
…70 - autocomplete pops up on readOnly inputs.
  • Loading branch information
scottgonzalez committed Oct 11, 2010
1 parent da13ea2 commit 450d030
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
File renamed without changes.
2 changes: 1 addition & 1 deletion ui/jquery.ui.autocomplete.js
Expand Up @@ -41,7 +41,7 @@ $.widget( "ui.autocomplete", {
"aria-haspopup": "true" "aria-haspopup": "true"
}) })
.bind( "keydown.autocomplete", function( event ) { .bind( "keydown.autocomplete", function( event ) {
if ( self.options.disabled ) { if ( self.options.disabled || self.element.attr( "readonly" ) ) {
return; return;
} }


Expand Down

3 comments on commit 450d030

@jitter
Copy link

@jitter jitter commented on 450d030 Oct 11, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm why would you rename the jquery-1.4.2.js file? This breaks the whole uni-test-suite

@scottgonzalez
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, that was not supposed to be committed. Not sure why Git included that. Thanks for catching it.

@scottgonzalez
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7a3e334.

Please sign in to comment.