Spinner: Don't stop propagation for keydown events.

jquery · Aug 6, 2011 · c4bd14f · c4bd14f
1 parent 6981cab
commit c4bd14f
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/ui/jquery.ui.spinner.js b/ui/jquery.ui.spinner.js
@@ -66,9 +66,8 @@ $.widget( "ui.spinner", {
 		this.element.attr( "role", "spinbutton" );
 		this._bind({
 			keydown: function( event ) {
-				if ( this._start( event ) ) {
+				if ( this._start( event ) && this._keydown( event ) ) {
-					// TODO: don't stop propagation
+					event.preventDefault();
-					return this._keydown( event );
 				}
 			},
 			keyup: function( event ) {
@@ -144,21 +143,21 @@ $.widget( "ui.spinner", {
 		switch ( event.keyCode ) {
 		case keyCode.UP:
 			this._repeat( null, 1, event );
-			return false;
+			return true;
 		case keyCode.DOWN:
 			this._repeat( null, -1, event );
-			return false;
+			return true;
 		case keyCode.PAGE_UP:
 			this._repeat( null, options.page, event );
-			return false;
+			return true;
 		case keyCode.PAGE_DOWN:
 			this._repeat( null, -options.page, event );
-			return false;
+			return true;
 		case keyCode.ENTER:
 			this.value( this.element.val() );
 		}
 
-		return true;
+		return false;
 	},
 
 	_mousewheel: function() {