All: Delegate to base _getCreateOptions().

Ensures that any extensions to the base widget will be handled properly by individual widgets. Closes gh-1598
jquery · Sep 17, 2015 · e19d462 · e19d462
1 parent afbcdbe
commit e19d462
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/tests/unit/widget/core.js b/tests/unit/widget/core.js
@@ -267,14 +267,17 @@ test( "merge multiple option arguments", function() {
 } );
 
 test( "._getCreateOptions()", function() {
-	expect( 3 );
+	expect( 4 );
 	$.widget( "ui.testWidget", {
 		options: {
 			option1: "valuex",
 			option2: "valuex",
 			option3: "value3"
 		},
 		_getCreateOptions: function() {
+			var superOptions = this._super();
+
+			deepEqual( superOptions, {}, "Base implementation returns empty object" );
 
 			// Support: IE8
 			// Strict equality fails when comparing this.window in ie8

diff --git a/ui/widget.js b/ui/widget.js
@@ -322,7 +322,9 @@ $.Widget.prototype = {
 		this._init();
 	},
 
-	_getCreateOptions: $.noop,
+	_getCreateOptions: function() {
+		return {};
+	},
 
 	_getCreateEventData: $.noop,
 

diff --git a/ui/widgets/selectmenu.js b/ui/widgets/selectmenu.js
@@ -646,7 +646,11 @@ return $.widget( "ui.selectmenu", {
 	},
 
 	_getCreateOptions: function() {
-		return { disabled: this.element.prop( "disabled" ) };
+		var options = this._super();
+
+		options.disabled = this.element.prop( "disabled" );
+
+		return options;
 	},
 
 	_parseOptions: function( options ) {

diff --git a/ui/widgets/spinner.js b/ui/widgets/spinner.js
@@ -104,8 +104,8 @@ $.widget( "ui.spinner", {
 	},
 
 	_getCreateOptions: function() {
-		var options = {},
+		var options = this._super();
-			element = this.element;
+		var element = this.element;
 
 		$.each( [ "min", "max", "step" ], function( i, option ) {
 			var value = element.attr( option );