Move start/stop to assert

[jzaefferer]

As a follow-up to #374 and #588, we want to move the stop and start methods to the assert object. As before, this needs to be backwards compatible, so the existing methods need to stay for now.

[leobalter]

@Krinkle, looks like with this follow-up issue we can close #374 or there are more things we should address?

[jzaefferer]

#374 is already closed.

[JamesMGreene]

I thought we were going with a new API, e.g. var done = assert.async(); /* ...do work... */ done();

Is moving start and stop to the assert context just necessary for the proper completion of #374, or is that the API we're going to continue using in v2.0 as well?

[leobalter]

done = assert.async(); implementation is way better, and we can change this issue to target it.

Anyway, it's too complex to move start and stop to the assert and make it object independent.

[Krinkle]

Yeah, I'd support closing this issue in favour of #534.

It'd be nice for the start/stop system to not make it to the v2.0 era (maybe as a deprecated back-compat layer, but it's replacement should be in there).

[jzaefferer]

Agreed, stop/start as is should be available for migration, to be replaced by #534. An intermediate step of moving to assert doesn't make sense.