Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent error messages in downloadable version, not CDN #779

Open
baskettcase opened this issue Jun 4, 2012 · 3 comments
Open

Persistent error messages in downloadable version, not CDN #779

baskettcase opened this issue Jun 4, 2012 · 3 comments

Comments

@baskettcase
Copy link

The validation plugin, when downloaded, doesn't seem to remove the error when the input field has been corrected, yet it does work with the CDN version: http://cdn.jquerytools.org/1.2.7/form/jquery.tools.min.js

To test this, I downloaded the three form plugins from your site (since I couldn't just test the validator plugin due to there not being a CDN version, so I needed to copy a CDN version to compare apples with apples), submitted my form and it showed that the email address needed to be filled in. I started typing the email address and when I finished the error message was still there. The desired result is that as soon as it was a valid email the alert should have disappeared. When I copy and paste from the cdn version of the three form plugins.. it does work as desired and expected.

Im concluding that what I get from the downloaded plugin from the site is different then what is hosted by CDN.

@baskettcase
Copy link
Author

I just tested the current raw version here on github and that worked fine. I then minified it using this site: http://www.minifyjavascript.com/ and it still works fine.. so Im beginning to think that the tool that minifies the code for export on the jquery tools site is actually messed up?

@alibby251
Copy link
Contributor

Hi baskettcase,

I've only just seen this - apologies for not responding sooner; hopefully I can clarify a few things:

The code available in CDN is actually the same minified code used when downloading individual/custom build versions of any of the Tools - in fact, as part of releasing the code to production use, I take copies of each minified element of Tools, and paste them into one file, depending on which version of the CDN file I'm working on. The minifier used in each instance though is Google's Closure Compiler - I believe this is what Tero originally used, and which he found gave the best results when minifying the code?

This said, I've seen instances over the last few years of supporting Tools, where people have reported that Validator doesn't seem to respond as it should - if you are still watching this, are you able to post a demo so I can see this in action please?

I am working though on the next release of Tools (which will be 1.2.8, using jQuery 1.9.1) - I've put together a demo as part of my testing, which uses the unminified source of Validator, and does what I believe you are looking for - it's at http://jsfiddle.net/alibby251/X3Tpt/1/. Please feel free to check it out - I will make a note to test it with a view to the above, once it has been minified for inclusion in the next release?

@baskettcase
Copy link
Author

Hi alibby251 this was quite a long time ago and since it is a live site, no I can't really post an exact demo. We are about to go live with another bundle so I will have to test the new tools with the new version of jQuery at a later date. It might actually be awhile before I can use the new jQuery due to all the plugins that I currently use and no clue if they are compatible :) Thanks for the follow up though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants