Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better clarify supported node versions #36

Closed
5 tasks done
jr-cologne opened this issue Oct 2, 2019 · 4 comments
Closed
5 tasks done

Better clarify supported node versions #36

jr-cologne opened this issue Oct 2, 2019 · 4 comments

Comments

@jr-cologne
Copy link
Owner

jr-cologne commented Oct 2, 2019

Hi there, dear Hacktoberfest contributors,

it would be good if we could better clarify which node versions are supported by this Gulp Starter Kit.

I think, it would be enough to add a more specific description of our requirements with regards to Node.js to our README file. But, in case you've any better ideas how to better clarify supported node versions, feel free to suggest them.

Here's a quick list about what is involved in this issue:

  • Comment here to let others know you would like to take this issue
  • Follow our quick contributing guide starting from step 2
  • Check out the required node versions of the project's dependencies
  • Consider v8+ as the requirement, but make sure all dependencies match this requirement
  • Make your changes to the documentation to inform users about our supported node versions

All right, have fun and celebrate Hacktoberfest with us! 🎉

Thank you very much in advance, I really appreciate your contribution!

Best regards,
@jr-cologne

@jr-cologne jr-cologne added this to the v1 milestone Oct 2, 2019
@jr-cologne jr-cologne self-assigned this Oct 2, 2019
@jr-cologne jr-cologne added this to To do in v1 via automation Oct 2, 2019
@parikshitgupta1

This comment has been minimized.

@drishit96
Copy link
Contributor

I would like to work on this

@drishit96
Copy link
Contributor

For specifying a specific Node.js version, the engines field in package.json can be used.
As mentioned here: https://stackoverflow.com/a/29349773/5987223

@jr-cologne
Copy link
Owner Author

Cool, go for it! 👍

Feel free to add the engines field to package.json as well.

v1 automation moved this from To do to Done Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1
  
Done
Development

No branches or pull requests

3 participants