tivolibre logic doesn't work on Windows?

[jradwan]

When trying to use the tivolibre functionality on Windows, the download (or stream) "completes" almost right away (without doing anything):

download:

2018-06-03 18:19:37,322 (2d6c) :  DEBUG (logkit:13) - CMD: "C:\Users\username\AppData\Local\Plex Media Server\Plug-ins\TiVoToGo.bundle\Contents\Resources\win\curl.exe" "http://192.168.1.73:80/download/Colony.TiVo?Container=%2FNowPlaying&id=49643" --digest -s -u tivo:<MAK>5 -c "c:\users\username\appdata\local\temp/cookies.txt"
2018-06-03 18:19:37,334 (2d6c) :  DEBUG (logkit:13) - PIPED to: "C:\Program Files (x86)\Java\jre1.8.0_171\bin\java.exe" -jar "C:\Users\username\AppData\Local\Plex Media Server\Plug-ins\TiVoToGo.bundle\Contents\Resources\TivoDecoder.jar" -m <MAK> -o "C:\Users\Username\Videos\Colony - End of the Road.mpg" -
...
2018-06-03 18:19:44,487 (2d6c) :  INFO (logkit:16) - Download complete: C:\Users\Username\Videos\Colony - End of the Road.mpg

stream:

2018-06-03 18:21:58,213 (13a4) :  DEBUG (logkit:13) - CMD: "C:\Users\username\AppData\Local\Plex Media Server\Plug-ins\TiVoToGo.bundle\Contents\Resources\win\curl.exe" "http://192.168.1.73:80/download/Colony.TiVo?Container=%2FNowPlaying&id=49643" --digest -s -u tivo:<MAK> -c "c:\users\username\appdata\local\temp/cookies.txt"
2018-06-03 18:21:58,221 (13a4) :  DEBUG (logkit:13) - PIPED to: "C:\Program Files (x86)\Java\jre1.8.0_171\bin\java.exe" -jar "C:\Users\username\AppData\Local\Plex Media Server\Plug-ins\TiVoToGo.bundle\Contents\Resources\TivoDecoder.jar" -m <MAK> -
2018-06-03 18:21:58,233 (13a4) :  INFO (logkit:16) - Starting decoder
2018-06-03 18:21:58,710 (13a4) :  INFO (logkit:16) - Self-exit of tivodecode/curl
2018-06-03 18:21:58,710 (13a4) :  INFO (logkit:16) - tivodecode/curl terminated

All of the paths are correct, and if you copy/paste the "CMD" and "PIPED to" debug lines to a Windows command prompt they work just fine. So it seems to be something related to the paths (embedded spaces?) and how Python is handing them in the command-lines for Windows (this all works fine on Linux and obviously the existing tivodecode calls work fine ... so something related to the Java command-line?).

[stephenwheet]

The problem with it not working on Windows is the spaces in the default path of Plex Media server. It's not parsing correctly. Just add shell=True to the tivodecode line of your code (I think 338 and 439) and let python do all the escape squences for you.. it works great.

tivodecode = Popen([java_path, "-jar", tvd, "-m", getMyMAK(), "-"],stdin=curlp.stdout, shell=True, stdout=PIPE)

[jradwan]

Thanks, I'll try this out!

[jradwan]

@stephenwheet thanks, that seems to work! Although 'shell=True' seems to break the command-line for Linux, so I had to put in an OS check and only add the 'shell=True' for win32.